Skip to content

chore: remove an outdated comment #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CHr15F0x merged 2 commits into from
Apr 23, 2026
+0 −15
Merged

chore: remove an outdated comment #3359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db6dacb
chore: remove an outdated comment
CHr15F0x Apr 22, 2026
5ae450f
chore: remove an outdated comment
CHr15F0x Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions crates/gateway-client/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,6 @@ pub trait GatewayApi: Sync {
unimplemented!();
}

/// This is a **temporary** measure to keep the sync logic unchanged
///
/// TODO remove when p2p friendly sync is implemented
async fn head(&self) -> Result<(BlockNumber, BlockHash), SequencerError> {
self.block_header(BlockId::Latest).await
}
Expand Down
12 changes: 0 additions & 12 deletions crates/pathfinder/src/consensus/inner/p2p_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,18 +541,6 @@ pub fn spawn(
// execution needs to be finalized and the resulting block has to be committed
// to the main database.
P2PTaskEvent::MarkBlockAsDecidedAndCleanUp(height_and_round, value) => {
// We do not have to commit these blocks to the main database
// anymore because they are being stored by the sync task (if enabled).
//
// TODO: Once we are ready to get rid of fake proposals, consider storing
// recently decided-upon blocks in memory (instead of a database) as
// "decided".
//
// NOTE: The main database still gets the state updates via consensus,
// which is the only reason why we still need the main database here at
// all. I could get it to work with only the consensus database in all
// scenarios except for when the node is chosen as a proposer and needs
// to cache the proposal for later.
tracing::info!(
"🖧 💾 {validator_address} Marking block at {height_and_round} as \
decided and cleaning up ..."
Expand Down
Loading