Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: runtime run as no-root user #6474

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

@CeerDecy CeerDecy commented Dec 6, 2024

What this PR does / why we need it:

runtime run as no-root user

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx

ChangeLog

Language Changelog
🇺🇸 English runtime run as no-root user
🇨🇳 中文 runtime以非root用户运行

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@CeerDecy CeerDecy requested review from iutx and sfwn and removed request for iutx December 6, 2024 07:40
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (af9ed3d) to head (73099de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...trator/scheduler/executor/plugins/k8s/daemonset.go 0.00% 14 Missing ⚠️
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 73.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6474      +/-   ##
==========================================
- Coverage   15.13%   15.12%   -0.01%     
==========================================
  Files        3683     3683              
  Lines      377026   377058      +32     
==========================================
- Hits        57057    57044      -13     
- Misses     314511   314564      +53     
+ Partials     5458     5450       -8     
Flag Coverage Δ
by-github-actions 15.12% <45.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rator/scheduler/executor/plugins/k8s/deployment.go 37.87% <100.00%> (+0.09%) ⬆️
...orchestrator/scheduler/executor/plugins/k8s/job.go 48.38% <100.00%> (+0.48%) ⬆️
...orchestrator/scheduler/executor/plugins/k8s/k8s.go 27.13% <73.33%> (+1.75%) ⬆️
...trator/scheduler/executor/plugins/k8s/daemonset.go 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

@CeerDecy CeerDecy marked this pull request as draft December 9, 2024 02:00
@CeerDecy CeerDecy marked this pull request as ready for review December 9, 2024 06:01
Copy link

stale bot commented Jan 3, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 3, 2025
@CeerDecy CeerDecy removed the wontfix label Jan 3, 2025
@erda-project erda-project deleted a comment from erda-bot Jan 4, 2025
Copy link
Member

@iutx iutx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the logic to plugins/k8s and add a global switch. @CeerDecy

@CeerDecy CeerDecy force-pushed the feature/run-as-user branch from 24f352b to da18275 Compare January 22, 2025 09:32
Copy link

stale bot commented Feb 12, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 12, 2025
@CeerDecy CeerDecy removed the wontfix label Feb 13, 2025
@CeerDecy CeerDecy force-pushed the feature/run-as-user branch from da18275 to 73099de Compare February 18, 2025 02:36
@sfwn
Copy link
Member

sfwn commented Feb 20, 2025

/assign @iutx

@erda-bot erda-bot requested a review from iutx February 20, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants