Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync general monitor config #6481

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CeerDecy
Copy link
Member

What this PR does / why we need it:

sync general monitor config, write log or metric into separate table under org

Which issue(s) this PR fixes:

Specified Reviewers:

/assign @iutx @sfwn

ChangeLog

Language Changelog
🇺🇸 English sync general monitor config, write log or metric into separate table under org
🇨🇳 中文 同步非应用的监控配置,将 logmetric 写入 org 下的单独表中

Need cherry-pick to release versions?

Add comment like /cherry-pick release/1.0 when this PR is merged.

For details on the cherry pick process, see the cherry pick requests section under CONTRIBUTING.md.

@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6481/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:34895: i/o timeout

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 193 lines in your changes missing coverage. Please review.

Project coverage is 15.29%. Comparing base (4dacc50) to head (c683dd0).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/tools/monitor/core/settings/sync_config.go 0.00% 95 Missing ⚠️
...al/tools/monitor/core/settings/settings.service.go 0.00% 36 Missing ⚠️
...tools/monitor/common/db/monitor_config_register.go 0.00% 32 Missing ⚠️
internal/tools/monitor/core/settings/monitor.go 0.00% 23 Missing and 1 partial ⚠️
internal/tools/monitor/common/db/db.go 0.00% 4 Missing ⚠️
internal/tools/monitor/common/db/table.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6481      +/-   ##
==========================================
+ Coverage   15.12%   15.29%   +0.16%     
==========================================
  Files        3675     3683       +8     
  Lines      377020   379394    +2374     
==========================================
+ Hits        57040    58017     +977     
- Misses     314530   315867    +1337     
- Partials     5450     5510      +60     
Flag Coverage Δ
by-github-actions 15.29% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/tools/monitor/common/db/table.go 0.00% <0.00%> (ø)
internal/tools/monitor/common/db/db.go 0.00% <0.00%> (ø)
internal/tools/monitor/core/settings/monitor.go 30.74% <0.00%> (-2.48%) ⬇️
...tools/monitor/common/db/monitor_config_register.go 0.00% <0.00%> (ø)
...al/tools/monitor/core/settings/settings.service.go 7.85% <0.00%> (-1.38%) ⬇️
...nternal/tools/monitor/core/settings/sync_config.go 0.00% <0.00%> (ø)

... and 34 files with indirect coverage changes

Copy link

stale bot commented Feb 6, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 6, 2025
@stale stale bot closed this Feb 14, 2025
@CeerDecy CeerDecy removed the wontfix label Feb 14, 2025
@CeerDecy CeerDecy reopened this Feb 14, 2025
@erda-bot
Copy link
Member

Add assignees failed, err: Post "https://api.github.com/repos/erda-project/erda/pulls/6481/requested_reviewers": proxyconnect tcp: dial tcp 8.218.184.45:35999: i/o timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants