Fix Issue 2206 Pt2 #2212
Merged
Fix Issue 2206 Pt2 #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the vector out of bounds access raised in Issue 2206. The root cause of the issue is that
ERF_Taggingoperates per level and thus the vectormf_cc_velshas 1 element for the current level. However, the called functionFillBdyCCVelsexpects that the vector of MFs to be of sizefinest_level. Therefore, we create an optional argument that allows us to modify the bounds of the outer for loop; this allowsFillBdyCCVelsto be called per level or for all levels.