Clean up Qmoist #2214
Merged
Clean up Qmoist #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qmoistwas previously a holder for moisture variables. Since we now transport each component, linear combinations of the moisture variables (e.g.,qt, qn, qp) are computed from the dycore variables. Therefore, the only variables the dycore may need to access are those that are derived from the state variables (e.g.,rain_accum, snow_accum, graup_accum). This PR cleans upqmoistto only encompass the variables that need access, and by extension, cleans up themicvar_map.This PR was tested for restart/plotting capabilities on the moist bubble with Kessler microphysics.