-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOST --> SurfaceLayer #2216
base: development
Are you sure you want to change the base?
MOST --> SurfaceLayer #2216
Conversation
The ABL_MYNN25 case confirms that the new SGSDiff method captures the appropriate diffusive flux while the development branch does not. The development branch yields an incorrect diffusive flux due to the averaging of At early times, the diffusive flux is under-predicted by 2X. |
@ewquon here are the GABLS results with SGSDiff: |
NOTE: THIS PR BREAKS BACKWARDS COMPATIBILITY FOR MOST BCs!
This PR overhauls the
ERF_ABLMost.H/cpp
implementation and renames itERF_SurfaceLayer.H/cpp
.The following paradigm is adopted:
SurfaceLayer
class only provides subgrid diffusive fluxes, it does NOT touch ghost cellssurface_layer
BC type, the lateral velocities and scalars are set toHOEXTRAP
so as to preserve their gradient as we go into ghost cells belowklo
. The normal velocity is set to0
with aDirichlet
condition. This allows us to NOT need special stencils with MOST since we will for example recover the samed_z u
as a one-sided diff and ensured_x w = 0
at the bottom surface.Things to be done: