EB Updates: (1) TerrainIF improvement, (2) SRD for RhoTheta_comp in erf_slow_rhs_post. #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewquon
pushed a commit
to ewquon/ERF
that referenced
this pull request
Mar 29, 2025
…rf_slow_rhs_post. (erf-model#2217) * Add function get_eb to return eb[lev]. * eb[lev]->define in ERF::MakeNewLevelFromScratch. * make_factory for eb_ instance in ERF::MakeNewLevelFromScratch. * EBFactory access to m_factory via eb_ instance. * Remove Factory() and replace it by EBFactory(). * Removed ERF class member m_factory: it is replaced by eb_. * Removed whitespaces. * Modified TerrainIF: different interpolations in nine sub-reginons of x-y plane. * Corrected TerrainIF. * Made redistribute_term a free function. * Added header files to CMakeLists.txt. * Call redistribute_term in erf_slow_rhs_post for RhoScalar. * Corrected S_sum update after SRD in no_substep_fun. * Update S_new not S_data in SlowRhsPost. * Updated EB_Test/inputs. * Removed whitespaces. * Removed commented out lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two updates on EB work:
TerrainIF::operator()has been corrected by properly handling the boundaries and corner points of the box. Now, the bilinear interpolation is performed only in the interior region of valid box. At the boundaries and ghost cells, 1D interpolation is applied or corner value is picked up.erf_slow_rhs_post.With these, the scalar transport test case in EB_Test runs stably.
In addition,