Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented AdvectionSrcForMom_EB. #2229

Merged
merged 11 commits into from
Apr 2, 2025
Merged

Conversation

skang67
Copy link
Contributor

@skang67 skang67 commented Apr 2, 2025

This PR implements RHS calculation for momentum variables (AdvectionSrcForMom_EB).

  1. The highest upwind order is determined using flag.isCovered(). If the specified advection scheme is not applicable, it is reduced to CENTERED2 or UPWIND3.
  2. Fluxes for staggered grids are computed using EB datasets (eb_aux_).

Validation:

  • When the area and volume fractions are commented out, the function AdvectionSrcForMom_EB is backward compatible with AdvectionSrcForMom_ConstantDz, except for WENO schemes.
  • AdvectionSrcForMom_EB has not been validated for the EB test. We need SRD for momentum variables to have a stable simulation.

@asalmgren asalmgren merged commit 55358ec into erf-model:development Apr 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants