Skip to content
This repository was archived by the owner on Feb 13, 2023. It is now read-only.

bugfix: grid filter empty record wrong values #1204

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix: grid filter empty record wrong values #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a710a1
bugfix: grid filter empty record wrong values
bleto Jan 31, 2022
a886966
text: update unit test
bleto Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions modules/@ergonode/core/src/models/mappers/__tests__/gridDataMapper.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,33 @@ describe('gridDataMapper/getParsedFiltersList', () => {

expect(getParsedFiltersList(filters)).toStrictEqual(result);
});

it('Validate filters with empty records', () => {
const filters = {
'code_2:en_GB': {
isEmptyRecord: true,
},
code_3: {
isEmptyRecord: true,
},
};

const result = [
{
column: 'code_2',
operator: '=',
value: null,
language: 'en_GB',
},
{
column: 'code_3',
operator: '=',
value: null,
},
];

expect(getParsedFiltersList(filters)).toStrictEqual(result);
});
});

describe('gridDataMapper/getDraftsBasedOnCellValues', () => {
Expand Down
4 changes: 2 additions & 2 deletions modules/@ergonode/core/src/models/mappers/gridDataMapper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ export function getParsedFiltersList(filters) {
&& (value || value === 0))) {
const parsedFilter = {
column: code,
operator,
value,
operator: operator === 'isEmptyRecord' ? '=' : operator,
value: operator === 'isEmptyRecord' ? null : value,
};

if (language) {
Expand Down