I1668 scan id from short to int

[pragmaxim]

See #1668

I tested it and all works fine :

• creating some scans with 4.0.35
• starting 4.0.36 that migrates these scans from Short to Int
• testing API
• shutdown and run 4.0.36 again
• testing boot up and API

[kushti]

It seems that old indexes (built with composeKey* functions) can be damaged. Please check and do new tests accordingly

[pragmaxim]

@kushti how did you find it can be damaged? I could use some clue

[pragmaxim]

@kushti I think you misunderstood the logic behind migration, I described it here #1668 (comment) ... we migrate the ids at the boot time and then we type-safely work only with Ints

[kushti]

@kushti I think you misunderstood the logic behind migration, I described it here #1668 (comment) ... we migrate the ids at the boot time and then we type-safely work only with Ints

How did you test it ?

[pragmaxim]

@kushti the sequence of testing steps is in the PR description.

[kushti]

@pragmaxim made custom testing, no results returned for old scans

[pragmaxim]

@kushti I was working on this almost 14 months ago, it is too stale for me to continue ... the LevelDB layer is very hard to reason about