ct: Remove usage of deprecated ct_slave in tests #9560
Conversation
The only change here I'm a bit unsure about is the `cth_auto_clean` suite, it is unclear to me why the application master is not started in `init_per_suite` already, as I can't find any call to start an app inbetween.
Since peer is way less talkative on the console, trim the remaining logs too, such that we can use e.g. `cte_track` for clean console output.
CT Test Results 2 files 57 suites 1h 11m 29s ⏱️ Results for commit 65fe335. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
I tried configuring cte_track for common_test once or twice, never finished. thanks for making an attempt! |
| @@ -1,2 +1,3 @@ | |||
| {suites,"../common_test_test",all}. | |||
| {skip_suites,"../common_test_test",[ct_release_test_SUITE],"Versions not always correct"}. | |||
| {event_handler, {cte_track, []}}. | |||
There was a problem hiding this comment.
{enable_builtin_hooks, false}. addition is not needed? no logger events messing the output?
maybe they're generated less frequently for common_test suites ...
There was a problem hiding this comment.
Hmm, I made a local test run with -enable_builtin_hooks false but it didn't look like it make much of a difference. Some logs (e.g. ct:pal tests) run on the main node and thus always end up on the terminal. I've added it regardless in case I missed something^^
There was a problem hiding this comment.
OK. maybe it is not relevant for ct.
There was a problem hiding this comment.
Do you want me to remove the addition again?
do you mean the .. sequence of numbers? I saw that too, maybe we could move that into a |
I mean all leftovers, after changing pal->log and taking logger events out. |
I think those are mostly gone with peer, yeah: https://github.com/erlang/otp/actions/runs/14226758185/job/39868469457 I can check this out with a closer look next week, but I think the proper fix for that is to just run the tests that test |
These commits update the
common_testtest suite to:ct_slaveandslavemodules in tests (with the exception of thect_slavetests itself, and sometest_servertests fortest_server:start_node)ct:paltoct:login most top-level test suites (except forct_log_SUITE, which explicitly wants to test them), since the stdout ofpeernodes won't be shown on the main test nodes & IMO make sense to contain to the HTML logscte_trackevent handler in tests for both local and GitHub-based runsThe second and third commit are of course a bit opinionated, so I'm happy to drop them (and possibly make
peerlog to our stdout) if wanted.