Skip to content

Cleanup duplicated code around oidcc_token:validate_jwt/3 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2025
Merged

Cleanup duplicated code around oidcc_token:validate_jwt/3 #424

merged 1 commit into from
Feb 21, 2025

Conversation

maennchen
Copy link
Member

Fixes #423

@maennchen maennchen self-assigned this Feb 21, 2025
@maennchen maennchen mentioned this pull request Feb 21, 2025
Closed
@coveralls
Copy link

coveralls commented Feb 21, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 258

Details

  • 38 of 40 (95.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 91.924%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/oidcc_token.erl 38 40 95.0%
Totals Coverage Status
Change from base Build 233: 0.04%
Covered Lines: 1070
Relevant Lines: 1164
💛 - Coveralls

@maennchen maennchen force-pushed the jm/validate_jwt_options branch from 342a492 to 7de9f20 Compare February 21, 2025 20:46
Nezteb
Nezteb reviewed Feb 21, 2025
View reviewed changes
@maennchen
Cleanup duplicated code around oidcc_token:validate_jwt/3
2aef85b 
Document missing options and adds refresh handling
@maennchen maennchen force-pushed the jm/validate_jwt_options branch from 7de9f20 to 2aef85b Compare February 21, 2025 21:11
Nezteb
Nezteb approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@Nezteb Nezteb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failing tests, all of the changes look good to me!

EDIT: Jk you fixed those too. 😄

@maennchen
Copy link
Member Author

@Nezteb At some point I'll have to take the time to fix those. Since I've written them, the provider I test against did some changes and now everything is flaky.

@maennchen maennchen merged commit 0b76d76 into main Feb 21, 2025
26 checks passed
@maennchen maennchen deleted the jm/validate_jwt_options branch February 21, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nezteb Nezteb Nezteb approved these changes

Assignees

@maennchen maennchen

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document validate_jwt option trusted_audience (singular)
3 participants
@maennchen @coveralls @Nezteb