Skip to content

Add MailChimp to styles library #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add MailChimp to styles library #6

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a703c98
Add MailChimp to styles library
ChrisChinchilla Feb 2, 2020
84c9b99
Update library.json
ChrisChinchilla May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions library.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,11 @@
"description": "Naive linter for English prose for developers who can't write good and wanna learn to do other stuff good too.",
"homepage": "https://github.com/errata-ai/write-good",
"url": "https://github.com/errata-ai/write-good/releases/latest/download/write-good.zip"
},
{
"name": "MailChimp",
"description": "A Vale-compatible implementation of the MailChimp Style Guide.",
"homepage": "https://github.com/testthedocs/MailChimp",
"url": "https://github.com/errata-ai/Microsoft/releases/latest/download/Microsoft.zip"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be https://github.com/testthedocs/MailChimp/releases/latest/download/MailChimp.zip?
It redirects to https://github.com/testthedocs/MailChimp/archive/0.1.0.zip, but this results in a 404. Accessing this link directly works.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this needs fixing, I am doing that tomorrow

See the whole discussion in #5

}
]