This repository was archived by the owner on Feb 3, 2023. It is now read-only.
Open
Conversation
Collaborator
|
I like the PR. The code looks good, testing is pending time for integration. In the "config_drive_motor_neutral.py", I would leave the people a choice if they have motors with potentiometer and guide them with the old instructions trough the settings, while on others the proposed way seems appropriate. I also would leave the sample values and mark them clearly as calculation sample or even propose a small script to calculate the the neutral value as starting point based on the specifications of the motors (if known). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows configuring the drive motors' stop position entirely in software. I made this, since I cannot easily configure my drive motors, because they are just patched servos.