-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes local container #616
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.1.0 #616 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 76 76
Lines 2752 2752
Branches 416 416
=======================================
Hits 2712 2712
Misses 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is this another "intermittent" error?
|
There might be an issue specific to the Helm chart, looking into it now. |
Confirmed need to make another change to this PR. |
@sashakames @downiec Figured out the failing test, I forgot that the |
Description
This PR updates the local container to utilize the production entrypoint. This solves three issues; the first is HTML not rendering in the news widget, the second is correctly rendering the
index.html
andruntime_env.js
, and lastly fixing theruntime_env.js
being written to the correct directory for local development.Note that the
index.html
must continue to use$VAR
rather than%VAR%
. This enables runtime configuration, if%VAR%
is used then the build process will substitute the values breaking runtime configuration.Fixes # (issue)
#613
Type of change
How Has This Been Tested?
Checklist