Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App recoil refactoring #760

Draft
wants to merge 8 commits into
base: v1.3.5-release
Choose a base branch
from
Draft

Conversation

downiec
Copy link
Collaborator

@downiec downiec commented Mar 20, 2025

Description

Some refactoring to utilize recoil state and reduce amount of variables passed down through components.

How Has This Been Tested?

  • Local Pre-commit Checks
  • CI/CD Build

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • If applicable - I have commented my code, particularly in hard-to-understand areas
  • If applicable - I have made corresponding changes to the documentation
  • If applicable - I have added tests that prove my fix is effective or that my feature works
  • If applicable - New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sorry, something went wrong.

downiec added 8 commits March 6, 2025 17:28
… various components upon the main App component. Updated tests and added new recoil wrapper helper class that can set recoil state for tests.
…new recoil method. Updated customRender so that it can apply initial recoil state.
…oil state. Updated and modified the recoilWrapper to make it a singleton and then have it set defaults at the start of all the tests. Hopefully updating the test suite after refactoring will be more straight forward however still need to fix some broken tests.
@downiec downiec self-assigned this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant