Change existing log functions to use new logger #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Don't approve/merge this for now. I'm going to rebase it on to a better log base class and branch, which will have the config and handlers come from a config file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second of two initial log-related PRs which moves existing log functions and annotation/decorator log events for function calls to call the new Log util class, allowing a customer handler and levels to be defined for different calls.
This one is more optional, but it makes much more sense if a proper logging framework is in place to not have some code write straight to stdout/stderr.
It's currently based on the previous PR, but can be rebased on to
masteronce #162 is merged.