-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add missing type definitions #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5826543 to
d8f9980
Compare
scagood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me 🙇♂️
bea3155 to
479ac3d
Compare
e05e75f to
e603aa5
Compare
|
I'm thinking about adding some type tests to instill some more confidence, let me know if that's something you would be interested in. |
|
That very much would be! We have an issue in a different eslint-community repo to do exactly that (eslint-community/eslint-plugin-n#212). So I would (possibly) look to 'borrow' the prior art if you do end up adding some tests :) |
47d2440 to
8683642
Compare
|
Any update? Thanks 🙌 |
Sorry about that, I kind of got busy and neglected this, I did mention a while back that I think it's better if we do a full TS migration so the types remain accurate and stay in sync with the runtime code. That offer still stands, I would love to do that if you guys are okay with it. |
|
@aryaemami59 Awesome thanks 🙂 |
a2dd459 to
4f1f511
Compare
5ef2840 to
1e4b665
Compare
|
Looks great! Thank you 🚀 |
1e4b665 to
62ea794
Compare
f4d62f4 to
27f34f8
Compare
27f34f8 to
205fb26
Compare
205fb26 to
38d26a8
Compare
|
Curious if this is still moving forward? Need any help? |
|
@aryaemami59, is this ready enough to merge and leave a full typescript migration to another PR? It looks finished to me. |
|
@MichaelDeBoey @scagood can this be merged? |
|
Adding @G-Rath and @ethanwu10 as well |
|
Sorry for neglecting this. I'll update this soon. |
38d26a8 to
0c3e85e
Compare
0c3e85e to
b8e9a7a
Compare
|
This one should be good to go, thanks everyone for being patient, I appreciate it. I've also opened a separate PR for the full TypeScript migration, which is now ready for review: #266. |
|
aside: @aryaemami59 you are amazing! If you have the stamina to ever fix eslint-community/eslint-plugin-security#177 as well, you would be awesome x2 😆 |
|
@thernstig I'll do my best.
|
This PR: