Skip to content

Conversation

@aryaemami59
Copy link

This PR:

@aryaemami59 aryaemami59 force-pushed the type-definitions branch 2 times, most recently from 5826543 to d8f9980 Compare October 26, 2024 21:56
@aryaemami59 aryaemami59 marked this pull request as ready for review October 26, 2024 22:11
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me 🙇‍♂️

@aryaemami59 aryaemami59 force-pushed the type-definitions branch 2 times, most recently from e05e75f to e603aa5 Compare November 13, 2024 11:30
@aryaemami59
Copy link
Author

I'm thinking about adding some type tests to instill some more confidence, let me know if that's something you would be interested in.

@scagood
Copy link

scagood commented Nov 17, 2024

That very much would be!

We have an issue in a different eslint-community repo to do exactly that (eslint-community/eslint-plugin-n#212). So I would (possibly) look to 'borrow' the prior art if you do end up adding some tests :)

@carlocorradini
Copy link

Any update? Thanks 🙌

@aryaemami59
Copy link
Author

Any update? Thanks 🙌

Sorry about that, I kind of got busy and neglected this, I did mention a while back that I think it's better if we do a full TS migration so the types remain accurate and stay in sync with the runtime code. That offer still stands, I would love to do that if you guys are okay with it.

@carlocorradini
Copy link

@aryaemami59 Awesome thanks 🙂‍↕️🥳

@aryaemami59 aryaemami59 force-pushed the type-definitions branch 2 times, most recently from 5ef2840 to 1e4b665 Compare March 2, 2025 13:23
@tomer-dev
Copy link

Looks great! Thank you 🚀

@aryaemami59 aryaemami59 force-pushed the type-definitions branch 2 times, most recently from f4d62f4 to 27f34f8 Compare April 11, 2025 13:40
@michaelfaith
Copy link

Curious if this is still moving forward? Need any help?

@lishaduck
Copy link

lishaduck commented Jul 28, 2025

@aryaemami59, is this ready enough to merge and leave a full typescript migration to another PR? It looks finished to me.

@thernstig
Copy link

thernstig commented Sep 2, 2025

@MichaelDeBoey @scagood can this be merged?

@thernstig
Copy link

Adding @G-Rath and @ethanwu10 as well

@aryaemami59
Copy link
Author

Sorry for neglecting this. I'll update this soon.

@aryaemami59
Copy link
Author

This one should be good to go, thanks everyone for being patient, I appreciate it.

I've also opened a separate PR for the full TypeScript migration, which is now ready for review: #266.

@thernstig
Copy link

aside: @aryaemami59 you are amazing! If you have the stamina to ever fix eslint-community/eslint-plugin-security#177 as well, you would be awesome x2 😆

@aryaemami59
Copy link
Author

@thernstig I'll do my best.

aside: @aryaemami59 you are amazing! If you have the stamina to ever fix eslint-community/eslint-plugin-security#177 as well, you would be awesome x2 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing TypeScript declaration file

10 participants