Skip to content

fix: disallow extra properties in rule options #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreww2012
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

This PR simply disallows extra properties in rules' schemas which currently allow them.

What changes did you make? (Give an overview)

Related Issues

Fixes #196

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 14, 2025
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jul 14, 2025
Copy link

linux-foundation-easycla bot commented Jul 14, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 14, 2025
@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Jul 14, 2025
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to see only one rule needed this after all. 🙂

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Jul 17, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 8fd755d into eslint:main Jul 17, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug Something isn't working contributor pool
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: schemas of some rules allow extra properties
4 participants