Skip to content

chore: enable skipLibCheck #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request?

Prevents type errors from being reported when run inside a directory with node_modules/@types/sizzle. See: https://github.com/eslint/eslint/pull/19643/files#r2155194866

What changes did you make? (Give an overview)

Enables skipLibCheck to prevent type checking of external .d.ts files.

Related Issues

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 15, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Jul 17, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 17, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

This change makes sense to me, but I'd like to get another opinion before merging.

@lumirlumir lumirlumir moved this from Triaging to Second Review Needed in Triage Jul 17, 2025
@lumirlumir lumirlumir requested a review from a team July 17, 2025 14:17
@fasttime
Copy link
Member

Makes sense to me 👍

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 18cfbc1 into eslint:main Jul 17, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jul 17, 2025
@JoshuaKGoldberg JoshuaKGoldberg deleted the skipLibCheck branch July 17, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants