Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Nov 13, 2025

Prerequisites checklist

What is the purpose of this pull request?

This PR was prompted by #803.

In this PR, I've updated markdownlint to 0.46.0.

It seems the only blocker for #803 is the minor version update of markdownlint:

https://github.com/eslint/eslint.org/actions/runs/19236566083/job/54987966936?pr=803

image

Looking at the changelogs up to 0.46.0, there don't appear to be any blockers for this update aside from the addition of the MD059 and MD060 rule.

I've set the MD059 and MD060 rules to false to avoid warnings about non-descriptive link descriptions and table cells.

Change Logs: https://github.com/igorshubovych/markdownlint-cli/releases

What changes did you make? (Give an overview)

In this PR, I've updated markdownlint to 0.46.0.

Related Issues

Ref: #803

Is there anything you'd like reviewers to focus on?

N/A

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 13, 2025
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/hi-eslint/deploys/691f1932a1c3ed00086994c8
😎 Deploy Preview https://deploy-preview-840--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/zh-hans-eslint/deploys/691f19329a40ef00085e6d99
😎 Deploy Preview https://deploy-preview-840--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for new-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/new-eslint/deploys/691f1932a1c3ed00086994c3
😎 Deploy Preview https://deploy-preview-840--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/ja-eslint/deploys/691f193275540f0008daccb1
😎 Deploy Preview https://deploy-preview-840--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/fr-eslint/deploys/691f19321056e10008a2ccc7
😎 Deploy Preview https://deploy-preview-840--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/de-eslint/deploys/691f1932ff78a40008dcbc31
😎 Deploy Preview https://deploy-preview-840--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/pt-br-eslint/deploys/691f19320eadcf000817be91
😎 Deploy Preview https://deploy-preview-840--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 01ddeac
🔍 Latest deploy log https://app.netlify.com/projects/es-eslint/deploys/691f1932f784bf0007bf0b0d
😎 Deploy Preview https://deploy-preview-840--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir lumirlumir marked this pull request as ready for review November 13, 2025 13:24
@lumirlumir lumirlumir requested review from a team and aladdin-add November 13, 2025 13:24
@lumirlumir lumirlumir changed the title chore: update markdownlint to 0.45.0 chore: update markdownlint to 0.46.0 Nov 20, 2025
Copy link

@DMartens DMartens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks. Maybe we should activate descriptive link texts(MD059) in the future?
Leaving this open for aladdin-add to review.

@lumirlumir lumirlumir moved this from Needs Triage to Second Review Needed in Triage Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Second Review Needed

Development

Successfully merging this pull request may close these issues.

3 participants