Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix waiting for short periods #3093

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Fix waiting for short periods #3093

merged 6 commits into from
Feb 5, 2025

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Feb 4, 2025

This PR (built on top of #3083) shortens wait times in tests (which trigger this issue), and sets the interrupt enable sooner, and changes code to work with that.

@bugadani

This comment was marked as outdated.

@bugadani bugadani force-pushed the timer-fix branch 3 times, most recently from 4d17288 to 68d15b1 Compare February 4, 2025 14:51
@bugadani bugadani marked this pull request as draft February 5, 2025 08:44
@bugadani bugadani marked this pull request as ready for review February 5, 2025 08:57
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev added this pull request to the merge queue Feb 5, 2025
Merged via the queue into esp-rs:main with commit 3bca047 Feb 5, 2025
27 checks passed
@bugadani bugadani deleted the timer-fix branch February 5, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants