Skip to content

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 14, 2025

What does this implement/fix?

supports esphome/esphome#11229

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome (if applicable):

  • esphome/esphome#

Checklist:

  • The code change is tested and works locally.
  • If api.proto was modified, a linked pull request has been made to esphome with the same changes.
  • Tests have been added to verify that the new code works (under tests/ folder).

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1ae539f) to head (e06df8f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         3287      3287           
=========================================
  Hits          3287      3287           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #1395 will not alter performance

Comparing HomeassistantActionRequest_fixed_vector (e06df8f) with main (1ae539f)1

Summary

✅ 11 untouched

Footnotes

  1. No successful run was found on main (6d02c46) during the generation of this report, so 1ae539f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bdraco bdraco merged commit 9545c59 into main Oct 14, 2025
14 of 15 checks passed
@bdraco bdraco deleted the HomeassistantActionRequest_fixed_vector branch October 14, 2025 07:43
@bdraco bdraco added the minor label Oct 14, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Walkthrough

Updated aioesphomeapi/api.proto: added a new string field response_template (conditionally compiled and no-zero-copy) to HomeassistantActionRequest, and set fixed_vector = true on the repeated fields data, data_template, and variables.

Changes

Cohort / File(s) Summary
Proto schema: HomeassistantActionRequest
aioesphomeapi/api.proto
- Added field string response_template with options: no_zero_copy = true, field_ifdef = "USE_API_HOMEASSISTANT_ACTION_RESPONSES_JSON"
- Set (fixed_vector) = true on repeated fields: data, data_template, variables

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

minor

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and concisely describes the primary change by indicating that the HomeassistantActionRequest message is being converted to use the fixed_vector option, directly reflecting the modifications in the proto file without extraneous detail or ambiguity.
Description Check ✅ Passed The description references the relevant upstream esphome pull request and specifies that the change is a code quality improvement, directly relating to the modifications made in api.proto; it therefore satisfies the lenient requirement of being on-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch HomeassistantActionRequest_fixed_vector

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d02c46 and e06df8f.

📒 Files selected for processing (1)
  • aioesphomeapi/api.proto (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

  • Do not generate or add any sequence diagrams

Files:

  • aioesphomeapi/api.proto
🔇 Additional comments (1)
aioesphomeapi/api.proto (1)

779-781: Fixed-vector on repeated fields is Python-safe; verify C++ generator

  • Python protobuf ignores (fixed_vector), and existing model tests for data/data_template/variables pass unchanged.
  • Please confirm esphome C++ codegen compiles cleanly and container layout behaves as expected with (fixed_vector)=true.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant