Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmartPad EM32 Smart Plug Device #1005

Merged
merged 13 commits into from
Feb 13, 2025
Merged

Add SmartPad EM32 Smart Plug Device #1005

merged 13 commits into from
Feb 13, 2025

Conversation

Smartpadza
Copy link
Contributor

Brief description of the changes

This pull request to add our Preflashed Plug to the listed devices.

Type of changes

  • New device
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

  • [X ] There are no passwords or secrets references in any examples.
    The only exceptions are !secret wifi_ssid and !secret wifi_password.
  • The wifi or ethernet block has no static / manual ip address specified.
  • The first configuration provided should be hardware definitions only.
    A more involved example can be provided in a separate configuration block.

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 5f84ee6
🔍 Latest deploy log https://app.netlify.com/sites/esphome-devices/deploys/67ae75f74c399e0008d85561
😎 Deploy Preview https://deploy-preview-1005--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 3 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 89 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@tekmaven tekmaven added the made-for-esphome-pending Pending approval for Made for ESPHome label Feb 8, 2025
@tekmaven tekmaven requested a review from jesserockz February 8, 2025 14:21
Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made for ESPHome approval pending changes in source configuration, we can merge this PR if the flag is set to false now and can be changed in a PR in the future.

src/docs/devices/smartpad-em32-smart-plug/index.md Outdated Show resolved Hide resolved
@esphome esphome bot marked this pull request as draft February 13, 2025 22:15
@esphome
Copy link

esphome bot commented Feb 13, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jesserockz jesserockz removed the made-for-esphome-pending Pending approval for Made for ESPHome label Feb 13, 2025
@jesserockz jesserockz marked this pull request as ready for review February 13, 2025 22:44
@esphome esphome bot requested a review from jesserockz February 13, 2025 22:44
@jesserockz jesserockz enabled auto-merge (squash) February 13, 2025 23:55
@jesserockz jesserockz merged commit 49bf21a into esphome:main Feb 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants