-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(sdcard): add validation diagrams and SD Card tests #12121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello JakubAndrysek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 90 files 90 suites 27m 51s ⏱️ For more details on these errors, see this check. Results for commit fcae8c8. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive SD card validation infrastructure for multiple ESP32 board variants, including hardware wiring diagrams and extensive functional tests for SD card SPI connectivity.
Key Changes:
- Adds hardware validation diagrams for 5 ESP32 variants (ESP32, ESP32-C3, ESP32-C6, ESP32-S2, ESP32-S3) with microSD card wiring specifications
- Implements 10 comprehensive test cases covering basic operations, file I/O, directory management, and limits testing
- Creates a flexible test framework supporting multiple SPI configurations per board
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validation/sdcard/test_sdcard.py | Python test wrapper that invokes Unity test framework with 280-second timeout |
| tests/validation/sdcard/sdcard.ino | Main Arduino test suite with SPITestConfig class and 10 comprehensive SD card test functions |
| tests/validation/sdcard/diagram.esp32.json | Wokwi hardware diagram for ESP32 DevKit C V4 with two microSD cards on separate SPI buses |
| tests/validation/sdcard/diagram.esp32s3.json | Wokwi hardware diagram for ESP32-S3 DevKitC-1 with two microSD cards |
| tests/validation/sdcard/diagram.esp32s2.json | Wokwi hardware diagram for ESP32-S2 DevKitM-1 with two microSD cards (contains wiring error) |
| tests/validation/sdcard/diagram.esp32c6.json | Wokwi hardware diagram for ESP32-C6 DevKitC-1 with two microSD cards sharing SPI bus |
| tests/validation/sdcard/diagram.esp32c3.json | Wokwi hardware diagram for ESP32-C3 DevKitM-1 with single microSD card |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request adds new hardware validation diagrams and a basic test for SD card SPI connectivity across various ESP32 board variants. The main focus is to ensure compatibility and proper wiring for SD card modules on different ESP32 development boards.
Hardware validation diagrams:
diagram.esp32.jsonfor ESP32 DevKitC V4, showing connections for two microSD cards.diagram.esp32c3.jsonfor ESP32-C3 DevKitM-1, illustrating wiring for one microSD card.diagram.esp32c6.jsonfor ESP32-C6 DevKitC-1, including connections for two microSD cards.diagram.esp32s2.jsonfor ESP32-S2 DevKitM-1, detailing wiring for two microSD cards.diagram.esp32s3.jsonfor ESP32-S3 DevKitC-1, showing two microSD cards connected.Testing:
test_spiintest_sdcard.pyto check SD card communication, using Unity test output with a specified timeout.