Only allow a single BLE request at once #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set semaphore token number to 0 (1 allows for 2 parallel requests apparently) - Register/unregister response listener within semaphore protection
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the application with a custom provisioner firmware code, I noticed it may occasionally send a second request via BLE while still waiting for the previous one's response. When that happens, the response listener gets overwritten (or null'ed) and the response will just went by unprocessed.
The fix which worked for me was to set the semaphore token number to 0 and ensure that the listener is accessed only within the semaphore's protection.