-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components/fatfs): replace assert expression (IDFGH-14473) #15247
base: master
Are you sure you want to change the base?
Conversation
assert expressions in the diskio_wl.c file contains a magical calculations. This PR replaces them with an equality check.
👋 Hello safocl, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
assert expressions in the diskio_wl.c file contains a magical calculations. This PR replaces them with an equality check.
assert expressions in the diskio_wl.c file contains a magical calculations. This PR replaces them with an equality check. (error corrected)
assert expressions in the diskio_wl.c file contains a magical calculations. This PR replaces them with an equality check.
before:
assert(wl_handle + 1);
after:
assert(wl_handle != WL_INVALID_HANDLE);
Related
Fixes #15246
Checklist
Before submitting a Pull Request, please ensure the following: