Skip to content

Conversation

Lapshin
Copy link
Contributor

@Lapshin Lapshin commented Aug 28, 2025

Description

newlib component is going to be renamed to esp_libc
I don't see reasons for adding the component via PRIV_REQUIRES because it is already in g1_components

If you lack some private newlib headers, I believe they should be made public.

Related

  • ESP-IDF MR !41584

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@david-cermak david-cermak merged commit 4d52982 into espressif:master Sep 1, 2025
80 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants