Skip to content

[WIP] IEP-1510: User reported issue on ESP-IDF Manager logging added #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] IEP-1510: User reported issue on ESP-IDF Manager logging added #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d9ad26
logging added for user issue
alirana01 Apr 22, 2025
bfa9b6c
bumped version for user to install the archive as an update
alirana01 Apr 22, 2025
0d6f554
reverts to feature.xml
alirana01 Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/ManageEspIdfVersionsHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
File inputFile = new File(toolSetConfigFilePath());
if (!inputFile.exists())
{
inputFile.createNewFile();

Check warning on line 48 in bundles/com.espressif.idf.ui/src/com/espressif/idf/ui/tools/ManageEspIdfVersionsHandler.java

View workflow job for this annotation

GitHub Actions / spotbugs

RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 

Exceptional return value of java.io.File.createNewFile() ignored in com.espressif.idf.ui.tools.ManageEspIdfVersionsHandler$1.run()
Raw output 
This method returns a value that is not checked. The return value should be checked since it can indicate an unusual or unexpected function execution. For example, the File.delete() method returns false if the file could not be successfully deleted (rather than throwing an Exception). If you don't check the result, you won't notice if the method invocation signals unexpected behavior by returning an atypical return value.
}

IFile iFile = ResourcesPlugin.getWorkspace().getRoot()
Expand All @@ -65,8 +65,10 @@
IPath path = ResourcesPlugin.getWorkspace().getRoot().getLocation();
StringBuilder stringBuilder = new StringBuilder();
stringBuilder.append(path.toOSString());
Logger.log("Workspace path: " + stringBuilder.toString());
stringBuilder.append(File.separatorChar);
stringBuilder.append(IToolsInstallationWizardConstants.TOOL_SET_CONFIG_FILE);
Logger.log("Tool Set configuraion file Path: " + stringBuilder.toString());
return stringBuilder.toString();
}
}
3 changes: 2 additions & 1 deletion releng/com.espressif.idf.product/idf.product
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<?pde version="3.5"?>

<product name="Espressif-IDE" uid="com.espressif.idf.product" id="com.espressif.idf.branding.idf" application="org.eclipse.ui.ide.workbench" version="3.3.0" type="mixed" includeLaunchers="true" autoIncludeRequirements="true">
<product name="Espressif-IDE" uid="com.espressif.idf.product" id="com.espressif.idf.branding.idf" application="org.eclipse.ui.ide.workbench" version="3.3.1" type="mixed" includeLaunchers="true" autoIncludeRequirements="true">

<aboutInfo>
<image path="/com.espressif.idf.branding/icons/alt_about.png"/>
Expand Down Expand Up @@ -48,6 +48,7 @@
<windows include="false">org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-17</windows>
</vm>


<plugins>
<plugin id="org.eclipse.embedcdt.debug.gdbjtag.restart.ui"/>
</plugins>
Expand Down
Loading