-
Notifications
You must be signed in to change notification settings - Fork 38
Add import and export documentation #2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add import and export documentation #2422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving our documentations with assets 🙏
I've got multiple points to fix:
- Your current assets use a DLT file which isn't open source. Those assets need to be removed because we don't even own the content of the used DLT file. Instead I would suggest using the logs of chipmunk app itself (Can be found in
$HOME/.chipmunk/..) or the output of some long command (On linux I usejournalctlcommand). - We already have a part for exporting and importing filters in our current docs. You can check that and improve the docs there if needed, but this part should be intended to export and import the logs only. (The title of the new file should include that to avoid any confusion)
- The new file should be included in
mkdocs.ymlfile so it's part of the documentation. Also, you need to test the new docs on your machine using the commandmkdocs serve --open
Chipmunk docs are currently missing the information around import and export of the presets. This commit adds the missing documentaion
|
Do you think it does makes sense to document export the log, as user can only export and import is not possible. So Imo adding import search/filters documentation is main thing... |
Correct, sorry used to write export and import together. I would suggest naming the whole page
I think the current place for importing search and filters is suitable because all filters its related stuff are gathered in on document, making the users able to learn about the exporting and importing filters directly after learning about them. |
6d55406 to
a956a54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recordings are great thank 💯
I think you misunderstood what I've meant in the last comments. Here are more details:
- We need a stand-alone document with the name
Export Logs. This should contain info about exporting logs + the assets - We don't need to change anything in
search.mddocument.Export Logsisn't part of it (I was talking aboutExport/Import Presetsin the last comment and though that you wanted to move them to theExportingdocument) - We don't need the
Exportingstand-alone document
a956a54 to
190c5a6
Compare
190c5a6 to
cddce71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started with the review but I've found out that we still have multiple places where filters are mentioned in the export logs document and where importing filters is removed form filters document, so I don't think this PR is ready for review in this state.
Also, We don't need to break the documentation lines when they reach a certain length, since the web view will wrap them automatically as they fit. Having the breaks in the raw text is a little bit confusing.
fc6ac18 to
dc5ef20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comments
Also, we don't need to break the lines manually once they've reached a certain length in markdown files.
| **Raw** | ||
|
|
||
| 1. The filtered results are exported as a binary file. | ||
| 2. Useful when user wants to share only filtered logs from Chipmunk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be used to combine logs from different file sources into one binary files. This can be achieved when you add multiple file sources in one session, then the filter results will be from them all and the export will be a combination from concatenated files
| ### Exporting filters and presets | ||
|
|
||
| Along with the logs user can also export the filters for later use and sharing, | ||
| find out more how user can export the filters from Chipmunk | ||
| [here](../search/#importing-exporting-presets) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filters don't belong to this document. I thought that this document is just for exporting logs only
| find out more how user can export the filters from Chipmunk | ||
| [here](../search/#importing-exporting-presets) | ||
|
|
||
| ### Exporting Streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ### Exporting Streams' Logs or Export Logs from Streams could be a better fit
| icon: | ||
| admonition: | ||
| note: material/note | ||
| alert: material/alert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we need to add this here?
| - Overview: index.md | ||
| - Installation: installation.md | ||
| - Search: search.md | ||
| - Expor Logs: exporting.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change the name of the file to export_logs.md to match its title here.
Also, the title has a typo in it Export instead of Expor
|
|
||
| ### Exporting Streams | ||
|
|
||
| Chipmunk allows to render the streams of data from TCP or UDP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't 100% correct. I would replace it with something like Chipmunk supports parsing and analyzing logs from multiple stream sources. We don't need to start mentioning the sources because we have many TCP, UDP, The output of process commands and serial ports
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many line-breaks
Currently Chipmunk docs are missing information around importing and exporting functionality. This commit adds the page dedicated around import/export functionality in Chipmunk
Fixes #2417