Modify atomic tests to use atomic load #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the atomic tests in backendTests to use `atomic::load` rather than pure memory loads as per issue etascale#20.
lundgren87
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Aside from the one comment I left (which can most likely be left unchanged) I don't have any objections. There are tests that fail using OpenUCX over Infiniband (atomic tests), but these are not related to the changes here and are documented in a separate issue (#86).
| @@ -167,30 +170,27 @@ TEST_F(backendTest, loadOne) { | |||
| std::chrono::system_clock::now() + deadlock_threshold; | |||
| while(argo::backend::atomic::load(_c) != c_const) | |||
| ASSERT_LT(std::chrono::system_clock::now(), max_time); | |||
| ASSERT_EQ(c_const, *_c); | |||
There was a problem hiding this comment.
This is a slight change of behaviour, but ultimately I think it is sufficient to check that the while loop has finished in order to verify the removed ASSERT_EQ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the atomic tests in backendTests to use
atomic::loadrather than pure memory loads as per issue #20.This as a standalone PR, but also when cherry-picking the commit from #83, passes all tests with both
DEBUG=ON/OFF.