fix(usfm): stop leaking raw error detail in sync export 500s

[henrique221]

Part of #195.

Summary

The sync USFM export handlers (exportProjectUSFMRoute and the exportable-books
handler) returned the raw exception message to the client via details. The
full error is already logged server-side (logger.error → App Insights with
projectUnitId/bookIds), so this drops details from the client 500
responses and removes the now-unused ErrorResponse interface.

Scope

• Sync export path only. The async-pipeline handlers (/usfm/async) have the
  same pattern but are left for Async USFM export pipeline hardening (pre-enablement) #196 (async export pipeline hardening), where
  that handler is being reworked anyway.
• Independent of fix(auth): require authentication on bibles and USFM routes #189 (auth) — touches the handler bodies, not the route/middleware
  definitions; no overlap.

Companion

The user-facing half of #195 is in fluent-web: send credentials on the
export request + surface the server message in the export dialog (separate PR).

Test plan

• npm run typecheck
• npm run lint
• npm run test — 80/80 pass

Summary by CodeRabbit

• Bug Fixes

  • Enhanced error handling for export operations with simplified error responses. Error messages now provide generic information only, without exposing internal system details to users.

• Refactor

  • Removed unused error response helper type to streamline the codebase.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b97dc21e-1964-4586-8ef9-bb2729943704

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9517b and 7789c12.

📒 Files selected for processing (1)

• src/domains/usfm/usfm.route.ts

---

📝 Walkthrough

Walkthrough

Two catch blocks in usfm.route.ts are updated to remove the details field from 500 error responses. The "get exportable books" and synchronous USFM export routes now return only a generic error string, and the ErrorResponse helper type is removed.

Changes

USFM Route Error Response Hardening

Layer / File(s)	Summary
Strip raw error details from USFM route catch blocks src/domains/usfm/usfm.route.ts	Both catch blocks now return { error: '...' } with status 500, omitting the details field that previously forwarded raw internal error messages. The ErrorResponse helper type is removed alongside this change.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

• Export: surface failures to users + log to Azure (sync USFM export) #195: This PR directly implements the change described in that issue — removing raw error details from USFM export route catch responses to prevent internal error leakage.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and accurately summarizes the main change: removing raw error details from sync USFM export 500 responses, which is the primary objective of the pull request.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/195-usfm-export-error-handling

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}