fix(projects): delete chapter assignments across all project units

[henrique221]

From the code audit (untracked follow-up).

Problem

deleteByProject selected a single project unit with .limit(1) and deleted only that unit's chapter assignments. If a project ever has more than one project_unit, the other units' assignments are silently orphaned.

createProject currently makes exactly one unit, so this is latent today — but the cleanup shouldn't assume a 1:1 project↔unit relationship.

Fix

Replace the select-one + delete-by-id (two round-trips, in a transaction) with a single statement that deletes assignments for all of the project's units via a subquery — effectively:

DELETE FROM chapter_assignments
WHERE project_unit_id IN (SELECT id FROM project_units WHERE project_id = $1)
RETURNING id

One round-trip, no transaction needed (single atomic statement), and the empty case returns deletedCount: 0 naturally.

Test plan

• npm run typecheck
• npm run lint
• npm run test — 80/80 pass

Summary by CodeRabbit

• Bug Fixes
  • Deleting chapter assignments for a project now removes assignments across all units in that project, not just one.
  • The number of removed assignments is now reported more accurately after deletion.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 37013cd5-07c7-42a4-82d2-51ce92d6bc92

📥 Commits

Reviewing files that changed from the base of the PR and between bffc4c8 and 5199e0e.

📒 Files selected for processing (1)

• src/domains/projects/chapter-assignments/project-chapter-assignments.repository.ts

---

📝 Walkthrough

Walkthrough

deleteByProject now removes chapter assignments for every project unit with one delete query and returns the deleted count from that query.

Changes

Project chapter assignment deletion

Layer / File(s)	Summary
Bulk delete by project src/domains/projects/chapter-assignments/project-chapter-assignments.repository.ts	deleteByProject replaces the single-unit transactional flow with a bulk DELETE over all matching project units and uses the deleted rows to compute the return value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: deleting chapter assignments for all project units in a project.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/delete-project-assignments-all-units

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[henrique221]

@coderabbitai full review

[coderabbitai]

✅ Action performed

Full review finished.

[Copilot]

Pull request overview

This PR fixes a latent data-integrity issue in the projects domain by ensuring chapter assignments are deleted for all project units under a project, rather than only one unit.

Changes:

• Replaced a transaction-based “select one project unit + delete by that unit id” flow with a single DELETE ... WHERE project_unit_id IN (subquery) statement.
• Ensures multi-unit projects don’t leave orphaned chapter assignments and returns an accurate deletedCount.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.