docs(checks): proposal — highlight repeated words in the verse editor#328
docs(checks): proposal — highlight repeated words in the verse editor#328JEdward7777 wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR adds a new proposal document for highlighting repeated-word findings inside the verse editor. It covers the textarea constraint, four implementation options, shared requirements, and open decision questions. No code changes are included. ChangesProposal Documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/proposals/repeated-word-check/highlight-in-verse-suggestion.md`:
- Around line 247-250: The `/view` highlight note in the HL5 section overstates
that read-only coloring is independent of the earlier mapping work; update the
wording to make clear that the `start_position` to rendered-range mapping and
grapheme/NFC handling are still shared with the editable path. Adjust the
sentence in the HL5 bullet so it explicitly says `/view` highlighting is simpler
visually, but still depends on the same range-mapping implementation described
above, using the HL5 label and the repeated-word-check proposal text as the
anchor.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d2cc60d1-c763-47dc-9f78-f2c37f2b0dcf
📒 Files selected for processing (1)
docs/proposals/repeated-word-check/highlight-in-verse-suggestion.md
edffb3e to
b3d0cc0
Compare
|
Had a conversation with Joel, where he indicated that the highlighting he had requested is not in the editor pane but in the repeated word check cards themselves. Therefore this suggestion document needs to be updated before additional review is needed. |
|
Superseded by #345. This proposal analyzed highlighting the repeated word in the editor pane, which would have required moving the drafting surface to a rich-text/overlay editor. Talking it through in person, the actual ask was the much simpler in-card highlight — each check card now shows the verse text windowed around the match with the repeated word emphasized in place. Given the small scope, the solution is proposed via the implementation itself in #345 rather than a separate proposal round. Keeping this PR's editor-surface analysis as historical context in case in-editor highlighting is ever wanted. |
Summary
Docs-only proposal responding to feedback from @joelthe1 and Ulf (raised during the #305 review): add an in-editor highlight/underline as a second visual for the repeated-word check, so flagged words are visible in the verse text itself and not only in the Checks panel.
The proposal exists because in-text coloring is not a small change — the drafting target column is a plain
<textarea>, which cannot color individual words, and there is no rich-text editor dependency in the app today. Choosing how to enable per-word decoration is an editor-foundation decision the team should make together, so this goes out as a proposal rather than a unilateral implementation.📄 Read the full doc:
docs/proposals/repeated-word-check/highlight-in-verse-suggestion.mdWhat it covers
useRepeatedWordsCheck→useResolvedFindings→ChecksPanel).<textarea>constraint and the caret/IME/spellcheck/focus behaviors that must be preserved.Ask
Reviewers: please pick a direction (Q1–Q5 at the end of the doc). No code changes are included; this PR is the doc only.
Relates to #277, #278
Summary by CodeRabbit