Skip to content

fix witness generation#265

Merged
jsign merged 3 commits intomasterfrom
jsign-fix-filling
Mar 14, 2026
Merged

fix witness generation#265
jsign merged 3 commits intomasterfrom
jsign-fix-filling

Conversation

@jsign
Copy link
Collaborator

@jsign jsign commented Mar 13, 2026

The current stateless crate is quite broken for witness generation:

This is a blocking problem to allow generating execution witness in this repo, and can't leave this broken until this gets fixed in Reth (if ever). Had no other option to fork it and use the fixes directly, so at least we aren't blocked by this.

I think the ideal thing would be that evmone-t8n can allow generating the executionWitness in execution-specs, so we can fill the benchmarks directly with that (plus being spec compliant) and completely remove the need of requiring an EL in here to generate the execution witness.

@jsign
Copy link
Collaborator Author

jsign commented Mar 13, 2026

cc @kevaundray (for visibility) since I touched on the last paragraph yesterday in another chat

I think we can live with this Reth fork a bit... but looks the ideal solution isevmone-t8n, or eventually if things get completely broken with Reth and emvone isn't ready we might need to try doing the same approach but with Ethrex.

@jsign
Copy link
Collaborator Author

jsign commented Mar 13, 2026

This causes some probs with ere-guest stateless crate version -- I'll have to look more into it to make this mergeable.

@kevaundray
Copy link
Contributor

cc @kevaundray (for visibility) since I touched on the last paragraph yesterday in another chat

I think we can live with this Reth fork a bit... but looks the ideal solution isevmone-t8n, or eventually if things get completely broken with Reth and emvone isn't ready we might need to try doing the same approach but with Ethrex.

Maybe we can create an issue in execution specs in the future to specify the ask re evmone supporting eexecution witness

@jsign
Copy link
Collaborator Author

jsign commented Mar 13, 2026

cc @kevaundray (for visibility) since I touched on the last paragraph yesterday in another chat
I think we can live with this Reth fork a bit... but looks the ideal solution isevmone-t8n, or eventually if things get completely broken with Reth and emvone isn't ready we might need to try doing the same approach but with Ethrex.

Maybe we can create an issue in execution specs in the future to specify the ask re evmone supporting eexecution witness

cc @kevaundray (for visibility) since I touched on the last paragraph yesterday in another chat
I think we can live with this Reth fork a bit... but looks the ideal solution isevmone-t8n, or eventually if things get completely broken with Reth and emvone isn't ready we might need to try doing the same approach but with Ethrex.

Maybe we can create an issue in execution specs in the future to specify the ask re evmone supporting eexecution witness

Sounds good. I'll create the issue in some mins.

@jsign
Copy link
Collaborator Author

jsign commented Mar 13, 2026

Updating ere-guest to latest stateless unblocks this PR. Whenever that PR is merged, I'll update here and should be good to go.

Signed-off-by: Ignacio Hagopian <[email protected]>
@jsign jsign marked this pull request as ready for review March 14, 2026 13:47
@jsign jsign merged commit 63da9dd into master Mar 14, 2026
4 checks passed
@jsign jsign deleted the jsign-fix-filling branch March 14, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants