Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start build workflow on tag #154

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented Sep 16, 2024

Fixes #153

Related to #26

Changes

  • Trigger build workflow on tag starting with a v added to the repo.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

This will be tested during the next test release which should be in a few days.

Documentation

Requires documentation update

  • Yes
  • No

Eventually, this will have to be updated in a branch I'm working on for the release process.

Requires explanation in Release Notes

  • Yes
  • No

@remyroy remyroy marked this pull request as ready for review September 16, 2024 17:35
@valefar-on-discord valefar-on-discord merged commit b27e887 into eth-educators:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change ci-build workflow to automatically build release assets on tag added to the repo
2 participants