make defaults contextful #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debjit-bw
requested review from
valefar-on-discord and
remyroy
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make "amount" contextful. Chains like Gnosis have different default values and different scaling constants for amounts. Added a field called
prompt_markerto the callback so that it is aware of what command it is for. Modified theget_defaultfunction so it fetches the default from chain settings. Addedctx.paramsas an input to thevalidate_deposit_amountfunction as a keyword argument a scaling factor. The default amounts and scaling parameters are defined in the chain settings. These default values also added to helper text through a newget_amount_prompt_from_templatefunction.These changes allow the deposit cli to process chain-specific deviations from the standard defaults in a generalized way.
Related issue
Makes command defaults/values contextful. Not related to an existing issue.