Reworked setuptools and add github build process #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I also removed the use of setup.py as part of the Dockerfile and the Makefile. I've tested the Docker image and the Makefile and they are still working for me after those changes. |
valefar-on-discord
approved these changes
May 1, 2024
| ('../../staking_deposit/key_handling/key_derivation/word_lists/*.txt', './staking_deposit/key_handling/key_derivation/word_lists/'), | ||
| ('../../staking_deposit/intl', './staking_deposit/intl'), | ||
| ] | ||
| datas += copy_metadata('py_ecc') |
There was a problem hiding this comment.
Curious why we are doing this as well
There was a problem hiding this comment.
Both py_ecc and ssz are using importlib for metadata reflection/inspection during module load. It might have been added in a recent version. In any case, the app triggers an unhandled exception if that data is not included in the bundled binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11 and #26 .
This removes setuptools as part of main project dependencies, the use of setup.py. It adds a new way to run from the CLI using the standard way to run a module with Python. It updates the related README file sections. It adds ci-build workflow to build release assets using the Github workflow and the Github runners. The ci-build can only be started once it's in the main branch of the repo. In order to test this, you can merge it into your personal main branch and start the workflow manually by going into actions, selecting the ci-build workflow and clicking on Run workflow as detailed in https://docs.github.com/en/actions/using-workflows/manually-running-a-workflow .
There might be more work to be done for a full build and release workflow like a runner for Linux arm64, GPG signing, running tests against the resulting bundled binaries (the tests in
test_binary_btec_script.py,test_binary_deposit_script.py,test_btec_script.pyandtest_deposit_script.pyfor instance). These efforts can be completed in other PRs.