Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PGP signatures and attestations to build process #44

Merged
merged 10 commits into from
May 7, 2024

Conversation

remyroy
Copy link
Member

@remyroy remyroy commented May 6, 2024

This PR adds 2 new elements to our build process with Github workflows:

  1. It create PGP signatures based on the stored PGP private key with Github secrets. It expects 2 secrets: GPG_PRIVATE_KEY and PASSPHRASE as described with the import-gpg action. I've already added those to the eth-educators/ethstaker-deposit-cli repo. You can see the documentation on this for more details.
  2. It creates build attestations to create a strong link between the workflow used to create the release assets and the eventual releases. See the documentation for more details.

@remyroy
Copy link
Member Author

remyroy commented May 6, 2024

Fixes #31

@remyroy remyroy linked an issue May 6, 2024 that may be closed by this pull request
@remyroy
Copy link
Member Author

remyroy commented May 6, 2024

The public key used for the eth-educators/ethstaker-deposit-cli repo for now is:

-----BEGIN PGP PUBLIC KEY BLOCK-----

mDMEZjkpCRYJKwYBBAHaRw8BAQdA5vgWEja2G4GrVjZMnBIYmFrZvEnxuJ6uUS5s
adscmme0KEVEQyBTZWN1cml0eSA8ZWRjLXNlY3VyaXR5QGV0aHN0YWtlci5jYz6I
lgQTFggAPhYhBFT6BvwIYPwNzMaOPs6f8jkd8mNoBQJmOSkJAhsDBQk4ZAkABQsJ
CAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEM6f8jkd8mNoN7EBAKmmaW20VPreIvEv
QCf2CCeDqwW29MPmzAnFRBTRcqJjAQCu0Clw3k/jXJcv1mtHPpKLh5+9Nf5bsRnR
l86WZJc2Dw==
=IeL9
-----END PGP PUBLIC KEY BLOCK-----

Copy link
Collaborator

@valefar-on-discord valefar-on-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I testing this on my own branch and verified the gpg signature and the attestations without issue.

One small question:

.github/workflows/build.yml Show resolved Hide resolved
@valefar-on-discord valefar-on-discord merged commit 2a22142 into eth-educators:main May 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PGP signing for release assets
2 participants