AA-507 Min Penalty Threshold #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
Feb 11, 2025
| uint256 private constant PENALTY_PERCENT = 10; | ||
| // Threshold below which no penalty would be charged | ||
| uint256 private constant PENALTY_GAS_THRESHOLD = 4e4; |
There was a problem hiding this comment.
- don't use exponential notation in solidity code. better 40_000
- what is the rationale for this value?
| @@ -819,7 +822,7 @@ contract EntryPoint is IEntryPoint, StakeManager, NonceManager, ReentrancyGuardT | |||
|
|
|||
| function _getUnusedGasPenalty(uint256 gasUsed, uint256 gasLimit) internal pure returns (uint256) { | |||
| unchecked { | |||
| if (gasLimit <= gasUsed) { | |||
| if (gasLimit <= gasUsed || gasLimit - gasUsed <= PENALTY_GAS_THRESHOLD) { | |||
There was a problem hiding this comment.
Damn solidity, doesn't optimize gasLimit-gasUsed which is done twice...
better add below if (unusedGas<=PENALTY_GAS_THRESHOLD) return 0;
(which is also slightly more readable)
drortirosh
approved these changes
Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.