Remove extraneous ! from test commands
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `expect` and `assert` functions both accept `!` as their first argument, which negates the test. However, those functions were putting the `!` into the executed command, which is not correct shell syntax and can cause exrtraneous errors. The `!` is now `shift`ed out of the args and only the tested command is run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running tests in eth-p/best, where I received errors like the following:
I traced the problem back to this repo, and it looks like the command is being executed with the
!in front of it, which is (I think?) supposed to be syntax for theexpectfunction. I am not sure why this was working before, but at least on Bash version 5.2.15, this causes the error above. When the!isshifted out of the args, the error goes away and all test pass.