Skip to content

fix: backward-compat for ESM etherpad #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict';

const assert = require('assert').strict;
const log4js = require('ep_etherpad-lite/node_modules/log4js');
const {createLogger} = require('ep_plugin_helpers/logger');

const logger = log4js.getLogger('ep_disable_imports');
const logger = createLogger('ep_disable_imports');
Comment on lines +4 to +6

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for logger 📘 Rule violation ☼ Reliability

This PR changes the logging import to restore compatibility with upcoming ESM Etherpad, but it does
not add/update any regression test to verify the fix. Without a test, this compatibility behavior
can silently regress in future changes.
Agent Prompt 
## Issue description
A bug-fix/compatibility change was made (switching from `log4js` to `ep_plugin_helpers/logger`) without adding a regression test in the same commit.

## Issue Context
The project currently has no test script, so the fix is not automatically verifiable and could regress undetected.

## Fix Focus Areas
- index.js[4-6]
- package.json[6-9]
- test/logger-compat.test.js[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

let allow = new Set();
let deny = new Set();

Expand Down
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ep_disable_imports",
"version": "1.0.49",
"version": "1.0.50",
"description": "Etherpad plugin to selectively or completely disable imports.",
"main": "index.js",
"scripts": {
Expand Down Expand Up @@ -33,5 +33,8 @@
"funding": {
"type": "individual",
"url": "https://etherpad.org/"
},
"dependencies": {
"ep_plugin_helpers": "^0.6.7"
}
Comment on lines +36 to 39

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Lockfile not updated 🐞 Bug ☼ Reliability

package.json adds the ep_plugin_helpers runtime dependency but pnpm-lock.yaml still has no
corresponding dependency entry, so pnpm i --frozen-lockfile will fail. This can block the
automated release workflow (and any other frozen-lockfile installs).
Agent Prompt 
## Issue description
`package.json` now declares a new runtime dependency (`ep_plugin_helpers`), but `pnpm-lock.yaml` was not regenerated. Any CI/release step that runs `pnpm i --frozen-lockfile` will error due to the lockfile being out of sync with `package.json`.

## Issue Context
The release workflow explicitly installs with a frozen lockfile, which requires the lockfile to exactly match `package.json`.

## Fix Focus Areas
- package.json[33-39]
- pnpm-lock.yaml[7-20]
- .github/workflows/npmpublish.yml[54-73]

## What to change
1. Run `pnpm install` in the repo root to regenerate `pnpm-lock.yaml`.
2. Commit the resulting `pnpm-lock.yaml` changes (it should include `ep_plugin_helpers@^0.6.7` under the root importer dependencies and in the `packages:` section).
3. Re-run CI/release checks to confirm `pnpm i --frozen-lockfile` succeeds.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

}
Loading