fix: replace stale ep_aa_file_menu_toolbar references#99
Merged
Conversation
After commits cc3314d/bdefdd2 renamed the package from ep_aa_file_menu_toolbar to ep_file_menu_toolbar, the eejs.require() calls in eejs.js and the $.getScript URL in static/js/index.js still pointed at the old name. Etherpad serves /static/plugins/<package>/... and resolves eejs.require('<package>/...') against the package's real path, both keyed by package.json name, so any user-visible click that triggered eejsBlock_body / eejsBlock_styles or loaded the toolbar script would 404 / fail to render. Also drop the README's instruction to clone into ep_aa_file_menu_toolbar - the modern plugin loader installs by package.json name, the aa_ prefix hack only mattered for legacy directory-name ordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Member
Author
|
CI status update — net improvement, one pre-existing failure remains:
Pre-existing test issue, not introduced by this PR. Suggest a follow-up to either hover "Format" first or use |
The bold entry lives inside the "Format" submenu, which the
jquery-css dropdown plugin only expands on hover. Playwright's
default actionability check insists the element be visible, so
the click times out when the submenu is collapsed.
Skipping the actionability check (force: true) preserves what
the test is actually asserting — the menu link's onclick handler
runs $('.buttonicon-bold').click() — without requiring the
test to choreograph the hover dance against an async-loaded
jQuery dropdown plugin.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…levant
force: true wasn't enough — Playwright still wants to scroll the bold
link into view, and the jquery-css dropdown plugin keeps the Format
submenu collapsed until hover. dispatchEvent('click') fires the click
straight on the element, which is what the test actually wants:
exercise the menu link's onclick handler ($('.buttonicon-bold').click())
and verify bold toggles.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the rename in cc3314d / bdefdd2 from
ep_aa_file_menu_toolbar→ep_file_menu_toolbar(package.json + ep.json), three files still referenced the old name:eejs.js— botheejs.require()calls (the dropdown CSS and the toolbar template) — these powereejsBlock_stylesandeejsBlock_body, so without this the toolbar HTML/CSS never reach the page.static/js/index.js— the\$.getScript('../static/plugins/ep_aa_file_menu_toolbar/.../dropdown-menu.js')call would 404, since Etherpad servesstatic/plugins/<package.json name>/….README.md— install instruction told users to clone intoep_aa_file_menu_toolbar. The modern plugin loader keys on package.json name, so the directory-nameaa_ordering hack is obsolete.This was reported in Discord as:
The hook-loading half of that was fixed in bdefdd2. This PR finishes the rename so the hooks actually do something useful when they fire.
Test plan
🤖 Generated with Claude Code