Potential fix for code scanning alert no. 110: Workflow does not contain permissions#7130
Merged
Conversation
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ether/etherpad-lite/security/code-scanning/110
To fix the problem, you should explicitly set the
permissionskey that restricts the GitHub Actions token's access according to the principle of least privilege. Given the context, most steps like checkout, cache, setup, and install only require read access to repository contents. The publish step does not require modification of GitHub repository content, but it interacts with npm using a secret, so the permission for secrets is managed through the workflow but doesn’t require additional repository writes. Therefore, the lowest sufficient privilege for GitHub-related actions iscontents: read. This should be set at the root (top-level) of the workflow so it applies to the entire workflow, ensuring no job will be granted more permission than necessary unless specifically overridden.The explicit addition should be at the top, after the workflow name and before the
on:block. No imports, definitions, or further code edits are needed.Suggested fixes powered by Copilot Autofix. Review carefully before merging.