Skip to content

Fix backend-tests find pattern for versioned plugin paths #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
Mar 30, 2026
Merged

Fix backend-tests find pattern for versioned plugin paths #7398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/plugins/lib/backend-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
name: Run the backend tests
working-directory: ./etherpad-lite
run: |
res=$(find . -path "./src/plugin_packages/ep_*/static/tests/backend/specs/**" | wc -l)
res=$(find . -path "./src/plugin_packages/ep_*@*/static/tests/backend/specs/**" | wc -l)

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Mar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No regression test for glob 📘 Rule violation ⛯ Reliability

This PR fixes a bug in the backend test discovery glob but does not add any automated regression
test to ensure the versioned plugin path pattern continues to be detected. Without a regression
check, reverting or breaking the glob again would not be caught reliably by CI.
Agent Prompt 
## Issue description
The backend test discovery glob was fixed, but there is no regression test/assertion that would fail if the glob were reverted or broken again.

## Issue Context
The job currently relies on a `find ... -path "./src/plugin_packages/ep_*@*/..."` expression; a lightweight regression check can validate the expected versioned plugin directory format (e.g., create a temp directory structure and assert the `find` pattern matches it).

## Fix Focus Areas
- bin/plugins/lib/backend-tests.yml[65-68]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

if [ $res -eq 0 ]; then
echo "No backend tests found"
else
Expand Down
Loading