chore(root): drop three redundant top-level files#7839
Merged
Conversation
Three small clean-ups to make the project root easier to scan for new contributors: - best_practices.md was a near-duplicate of CONTRIBUTING.md. Merge its two unique bullets (PRs MUST include a description / flag empty descriptions as incomplete) into CONTRIBUTING.md and remove the file. - .pr_agent.toml is a two-line Qodo PR-bot config. It has no functional references in the repo and Qodo currently doesn't review this repo. - tests/ -> src/tests was an unused root symlink. Verified no workflow, script, eslint config, or playwright config relies on the root path (all callers use src/tests/... or the ep_etherpad-lite package path). No CI, build, or docs updates needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Review Summary by QodoClean up redundant root-level files and documentation WalkthroughsDescription• Delete redundant best_practices.md file, merging unique content into CONTRIBUTING.md • Remove unused .pr_agent.toml Qodo PR-bot configuration file • Delete root-level tests symlink pointing to src/tests • Add PR description requirements to CONTRIBUTING.md Diagramflowchart LR
A["Root Directory"] -->|"Delete best_practices.md"| B["CONTRIBUTING.md"]
A -->|"Merge PR rules"| B
A -->|"Delete .pr_agent.toml"| C["Removed"]
A -->|"Delete tests symlink"| D["Removed"]
B -->|"Updated with PR requirements"| E["Enhanced Guidelines"]
File Changes1. best_practices.md
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
Follow-up on Qodo review feedback for #7839: - CONTRIBUTING.md: front-end-tests path now reads src/tests/frontend/ instead of the dead tests/frontend/ (the root tests symlink is gone). The browser URL <yourdomainhere>/tests/frontend stays — that's an Express route served by the test runner, not a filesystem path. - docs/superpowers/specs/...openapi-design.md: drop best_practices.md from the parenthetical list of policy sources (now CONTRIBUTING.md and AGENTS.MD), since best_practices.md has been removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Why is now qodo not reviewing the repository? Besides that looks good. |
SamTV12345
approved these changes
May 25, 2026
SamTV12345
left a comment
SamTV12345
left a comment
Member
There was a problem hiding this comment.
As mentioned only thing being a bit striking is this qodo thing. But could be that I don't have the full picture. Looks like qodo is still working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Quick tidy-up of the project root so a new contributor lands on fewer ambiguous files. Three changes, no CI or build wiring touched:
best_practices.md— duplicate ofCONTRIBUTING.md. The two unique rules (PRs MUST include a description; flag empty descriptions as incomplete) are merged intoCONTRIBUTING.mdin the same commit..pr_agent.toml— Qodo PR-bot config with no functional refs in the repo; Qodo is not currently reviewing this repo.testssymlink (→src/tests) — Verified nothing relies on the root-relative path:src/tests/...bin/scripts use theep_etherpad-lite/tests/...package pathsrc/playwright.config.tstestDir issrc/src/.eslintrc.cjspatterns are relative tosrc/Root entry count drops 35 → 32. Larger reorgs (moving
settings.json.template,settings.json.docker,docker-compose.*, etc.) are intentionally out of scope — those touch many CI workflows and external user expectations and deserve their own discussion.Test plan
git grep best_practices,git grep pr_agent, and root-relativetests/patterns turn up only historical refs indocs/superpowers/