Skip to content

fix(release): sync src + bin package.json to 3.2.0 so release ships 3.3.0#7919

Merged
JohnMcLear merged 1 commit into
developfrom
fix-release-version-sync-3.3.0
Jun 9, 2026
Merged

fix(release): sync src + bin package.json to 3.2.0 so release ships 3.3.0#7919
JohnMcLear merged 1 commit into
developfrom
fix-release-version-sync-3.3.0

Conversation

@JohnMcLear

@JohnMcLear JohnMcLear commented Jun 9, 2026

Copy link
Copy Markdown
Member

PR Summary by Qodo

Fix release workflow by syncing src/bin package versions back to 3.2.0
🐞 Bug fix ⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

Walkthroughs

User Description

Why the release workflow is failing

The last two Release etherpad dispatches (2026-06-07, 2026-06-08) both failed at the Prepare release step:

Error: No changelog record for 3.4.0, please create changelog record
    at bin/release.ts:146

Root cause

3.3.0 was never released — the latest tag/release is v3.2.0 (2026-05-22). The repo already carries a complete # 3.3.0 changelog section, and the intent is to ship 3.3.0 next.

A prior commit (d09227b1, "3.2.0") reverted root and admin/ package.json back to 3.2.0 to set up a clean 3.2.0 → 3.3.0 minor bump — but missed src/package.json and bin/package.json, which were left at 3.3.0:

file before after
package.json (root) 3.2.0 3.2.0
admin/package.json 3.2.0 3.2.0
src/package.json 3.3.0 3.2.0
bin/package.json 3.3.0 3.2.0

bin/release.ts reads the current version from src/package.json, so it computed minor(3.3.0) = 3.4.0 and aborted on the missing # 3.4.0 changelog entry.

Fix

Sync src/package.json and bin/package.json back to 3.2.0 so all four package.json files agree. The next minor dispatch then computes 3.2.0 → 3.3.0, which satisfies the existing changelog guard (CHANGELOG.md opens with # 3.3.0).

Verified locally: CHANGELOG.md starts with # 3.3.0\n ✓, and release.ts will overwrite all four package.jsons to 3.3.0 during the bump.

🤖 Generated with Claude Code

AI Description
• Set src/ and bin/ package.json versions to 3.2.0 to match root/admin.
• Prevent release.ts from computing an incorrect next minor version (3.4.0).
• Unblock the next minor release dispatch to ship 3.3.0 using existing changelog.
Diagram
flowchart TD
  A(["Release dispatch"]) --> B["bin/release.ts"] --> C["src/package.json"] --> D{"Compute version"}
  D --> E["CHANGELOG.md"] --> F{"Changelog guard"}
  F --> G(["Write via jq"]) --> H["package.json files"]

  subgraph Legend
    direction LR
    _proc(["Process step"]) ~~~ _file["File"] ~~~ _dec{"Decision"}
  end
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Make release.ts read root package.json as version source
  • ➕ Aligns version source with the most obvious top-level manifest
  • ➕ Reduces risk of workspace subpackage drift affecting releases
  • ➖ May conflict with existing conventions if src/ is intended as the canonical package
  • ➖ Does not by itself prevent other package.json files from drifting
2. Add a preflight version consistency check across all package.json files
  • ➕ Fails fast with a clear error when versions diverge
  • ➕ Prevents this class of release breakage from recurring
  • ➖ Slightly more release-script complexity
  • ➖ Still requires someone to resolve the mismatch when it occurs
3. Centralize versioning via a single source + generation step
  • ➕ Eliminates manual multi-file version edits
  • ➕ Makes releases more deterministic
  • ➖ Higher change surface area than needed for the immediate unblock
  • ➖ May require tooling/process changes for maintainers

Recommendation: The PR’s approach is the right minimal unblock: syncing src/bin back to 3.2.0 restores the intended 3.2.0 → 3.3.0 minor bump and satisfies the existing changelog guard. Consider a small follow-up to add a preflight consistency check in bin/release.ts so mismatched package.json versions fail with an actionable error before computing a wrong target version.

Grey Divider

File Changes

Bug fix (1)
package.json Downgrade src package version to 3.2.0 (release version source) +1/-1

Downgrade src package version to 3.2.0 (release version source)

• Sets the src workspace package version from 3.3.0 back to 3.2.0. This fixes the release script’s currentVersion input, preventing it from computing a 3.4.0 target and failing the changelog guard.

src/package.json


Other (1)
package.json Downgrade bin package version to 3.2.0 for release consistency +1/-1

Downgrade bin package version to 3.2.0 for release consistency

• Sets the bin workspace package version from 3.3.0 back to 3.2.0. This aligns it with the repository’s expected pre-release state so the release bump logic targets 3.3.0 next.

bin/package.json


Grey Divider

Qodo Logo

…h targets 3.3.0

The Release workflow has failed on the last two dispatches with:

    Error: No changelog record for 3.4.0, please create changelog record
    at bin/release.ts:146

3.3.0 was never released (latest tag/release is v3.2.0). The repo already
carries a complete `# 3.3.0` changelog section, and the intent is to ship
3.3.0 next. A prior commit reverted the root and admin/ package.json back to
3.2.0 to set up a clean 3.2.0 -> 3.3.0 minor bump, but missed src/package.json
and bin/package.json, which were left at 3.3.0.

bin/release.ts reads the current version from src/package.json, so it computed
minor(3.3.0) = 3.4.0 and aborted on the missing 3.4.0 changelog. Syncing src
and bin back to 3.2.0 (matching root + admin) makes the next `minor` dispatch
compute 3.2.0 -> 3.3.0, which satisfies the existing changelog check.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Jun 9, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@JohnMcLear JohnMcLear merged commit 809b75c into develop Jun 9, 2026
32 of 33 checks passed
@JohnMcLear JohnMcLear deleted the fix-release-version-sync-3.3.0 branch June 9, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant