fix(release): sync src + bin package.json to 3.2.0 so release ships 3.3.0#7919
Merged
Conversation
…h targets 3.3.0
The Release workflow has failed on the last two dispatches with:
Error: No changelog record for 3.4.0, please create changelog record
at bin/release.ts:146
3.3.0 was never released (latest tag/release is v3.2.0). The repo already
carries a complete `# 3.3.0` changelog section, and the intent is to ship
3.3.0 next. A prior commit reverted the root and admin/ package.json back to
3.2.0 to set up a clean 3.2.0 -> 3.3.0 minor bump, but missed src/package.json
and bin/package.json, which were left at 3.3.0.
bin/release.ts reads the current version from src/package.json, so it computed
minor(3.3.0) = 3.4.0 and aborted on the missing 3.4.0 changelog. Syncing src
and bin back to 3.2.0 (matching root + admin) makes the next `minor` dispatch
compute 3.2.0 -> 3.3.0, which satisfies the existing changelog check.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary by Qodo
Fix release workflow by syncing src/bin package versions back to 3.2.0
🐞 Bug fix⚙️ Configuration changes🕐 Less than 10 minutesWalkthroughs
User Description
Why the release workflow is failing
The last two Release etherpad dispatches (2026-06-07, 2026-06-08) both failed at the Prepare release step:
Root cause
3.3.0 was never released — the latest tag/release is
v3.2.0(2026-05-22). The repo already carries a complete# 3.3.0changelog section, and the intent is to ship 3.3.0 next.A prior commit (
d09227b1, "3.2.0") reverted root and admin/package.jsonback to3.2.0to set up a clean3.2.0 → 3.3.0minor bump — but missedsrc/package.jsonandbin/package.json, which were left at3.3.0:package.json(root)admin/package.jsonsrc/package.jsonbin/package.jsonbin/release.tsreads the current version fromsrc/package.json, so it computedminor(3.3.0) = 3.4.0and aborted on the missing# 3.4.0changelog entry.Fix
Sync
src/package.jsonandbin/package.jsonback to3.2.0so all four package.json files agree. The nextminordispatch then computes3.2.0 → 3.3.0, which satisfies the existing changelog guard (CHANGELOG.mdopens with# 3.3.0).Verified locally:
CHANGELOG.mdstarts with# 3.3.0\n✓, andrelease.tswill overwrite all four package.jsons to3.3.0during the bump.🤖 Generated with Claude Code
AI Description
Diagram
flowchart TD A(["Release dispatch"]) --> B["bin/release.ts"] --> C["src/package.json"] --> D{"Compute version"} D --> E["CHANGELOG.md"] --> F{"Changelog guard"} F --> G(["Write via jq"]) --> H["package.json files"] subgraph Legend direction LR _proc(["Process step"]) ~~~ _file["File"] ~~~ _dec{"Decision"} endHigh-Level Assessment
The following are alternative approaches to this PR:
1. Make release.ts read root package.json as version source
2. Add a preflight version consistency check across all package.json files
3. Centralize versioning via a single source + generation step
Recommendation: The PR’s approach is the right minimal unblock: syncing src/bin back to 3.2.0 restores the intended 3.2.0 → 3.3.0 minor bump and satisfies the existing changelog guard. Consider a small follow-up to add a preflight consistency check in bin/release.ts so mismatched package.json versions fail with an actionable error before computing a wrong target version.
File Changes
Bug fix (1)
Other (1)