chore(devstack): remove NewMultiSupervisorInterop preset and dead code#20848
Merged
Conversation
The MultiSupervisorInterop preset existed only to give verifier nodes a second op-supervisor because op-supervisor did not support multi-node. The supernode-based presets cover the same scenarios now, and the only test that consumed this preset (interop_sync_test.go) was skipped at runtime. - Delete op-acceptance-tests/tests/interop/sync/multisupervisor_interop - Drop NewMultiSupervisorInterop / MultiSupervisorInterop and the multiSupervisorInteropFromRuntime / NewMultiSupervisorInteropRuntime factories. - Drop the now-unused MultiChainRuntime.SecondarySupervisor field. - Update the README example to point at a live test.
AwaitMinL1, AwaitMinCrossSafeTimestamp, AdvancedSafeHead, and AddManagedL2CL on dsl.Supervisor were only consumed by the deleted multi-supervisor interop test.
The op-devstack example tests were duplicated by the kona-supervisor integration tests, and were the only consumers of the dsl.Supervisor VerifySyncStatus helpers.
wwared
approved these changes
May 18, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MultiSupervisorInteroppreset only existed because op-supervisor did not support multi-node and so verifier nodes needed a second supervisor. The supernode-based presets cover the same ground, and the one test that consumed this preset (TestL2CLAheadOfSupervisorand friends) wasgt.Skip(...)-gated.After PR #20825, this was the last test outside
op-supervisor/that actually started an op-supervisor service. Removing it (plus the duplicated op-devstack example tests) removes the last non-op-supervisor/op-supervisor lifecycle dependency for the supernode path.Changes:
op-acceptance-tests/tests/interop/sync/multisupervisor_interop/.op-devstack/example/example_test.go(covered by the kona-supervisor integration tests).NewMultiSupervisorInterop/MultiSupervisorInteropandmultiSupervisorInteropFromRuntime/NewMultiSupervisorInteropRuntime.MultiChainRuntime.SecondarySupervisorfield.dsl.Supervisorhelpers used only by the removed tests:AwaitMinL1,AwaitMinCrossSafeTimestamp,AdvancedSafeHead,AddManagedL2CL,VerifySyncStatus(and its options).