fix(op-acceptance-tests): wait for EL labels in SafeHeadProgression#20852
Merged
Conversation
TestSupernodeInterop_SafeHeadProgression polled the CL until CrossSafe (and later Finalized) reached the target block, then immediately read the EL safe/finalized labels synchronously. The EL labels are updated asynchronously by an engine-API ForkchoiceUpdated dispatched after the CL marks the block, so a synchronous read can lag the CL by an FCU propagation window — long enough under CI scheduling pressure to fail the assertion (observed: CL at target=10, EL still at 9, ~9ms gap). Include the EL ReachedFn polls in the same dsl.CheckAll as the CL polls so each block confirms both CL and EL have reached the target before the subsequent synchronous BlockRefByLabel + GreaterOrEqual assertions run. Refs #20851
ajsutton
force-pushed
the
aj/fix/flake-safe-head-progression
branch
from
53b31cb to
6c2703d
Compare
Inphi
approved these changes
May 19, 2026
Contributor
Inphi
left a comment
Inphi
left a comment
There was a problem hiding this comment.
I wonder if we the ReachedFn could do this for the programmer. Where checking the CL auto-checks its corresponding EL as well by default.
The only reason why you'd possibly want to check the CL but not the CL is if you're testing some a weird FCU case.
Contributor
Author
|
That's a pretty good point actually. Probably bigger than I want to try and take on here as it crosses some boundaries in the DSL but it would make a lot of sense to just have the CL/EL pair represented more as a whole. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the flake in
TestSupernodeInterop_SafeHeadProgression(#20851).The test polled the CL until
CrossSafe/Finalizedreached the target, then synchronously read the corresponding EL label. The EL label is updated by an engine-APIForkchoiceUpdateddispatched asynchronously after the CL advances, so a synchronous read can lag the CL by an FCU-propagation window — long enough under CI scheduling pressure to fail the>= finalTargetBlockNumassertion. Failing run had the CL at target=10 and the EL still at 9 ~9ms later.Include the EL
ReachedFnpolls in the samedsl.CheckAllas the CL polls so each block waits for both CL and EL to reach the target before the synchronousBlockRefByLabel+GreaterOrEqualassertions run.