This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Enable Warp server only if we have snapshot #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
no-snapshot-no-warp
branch
from
25339df to
01f6f82
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4718 +/- ##
===========================================
- Coverage 60.72% 60.72% -0.01%
===========================================
Files 347 347
Lines 27221 27224 +3
Branches 2853 2849 -4
===========================================
Hits 16531 16531
- Misses 9693 9704 +11
+ Partials 997 989 -8 |
chfast
suggested changes
Dec 27, 2017
libethereum/WarpPeerCapability.cpp
Outdated
| @@ -33,29 +33,24 @@ void WarpPeerCapability::init(unsigned _hostProtocolVersion, u256 _hostNetworkId | |||
| u256 _chainTotalDifficulty, h256 _chainCurrentHash, h256 _chainGenesisHash, | |||
| std::shared_ptr<SnapshotStorageFace const> _snapshot) | |||
| { | |||
| assert(_snapshot); | |||
| m_snapshot = _snapshot; | |||
chfast
approved these changes
Dec 27, 2017
gumb0
force-pushed
the
no-snapshot-no-warp
branch
from
01f6f82 to
bf0011d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it always created Warp capability and reported snapshot number 0, snapshot hash 0.
Also imported snapshot path construction was duplicated in
SnapshotImporterandWarpHostCapability, now it's in a single place inimportedSnapshotPath()